Add depth to git_clone() - #281
Merged
Merged
Conversation
etiennebacher
marked this pull request as ready for review
July 21, 2026 11:20
Member
|
Thank you. Could you change this into a warning: Rf_error("Shallow clone (depth) requires libgit2 >= 1.7.0");The reason is that I worry that people may not realize that using this parameter will break your R code on systems with a somewhat older libgit2. I think in this case, it is better to fall back to doing the non-shallow clone, with a warning, rather than error out. |
Contributor
Author
|
Done. BTW, the current test suite ignores some (unrelated) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was almost entirely generated by Claude, but I expanded and modified the tests it generated. I also re-built the package with this change and checked that it worked fine.
Fixes #101
Ref in
libgit2: https://github.com/libgit2/libgit2/releases/tag/v1.7.0